-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractKafkaStreamsBinderProcessor ignores TimestampExtractor configuration starting with kafka-streams 3.7.0 #2922
Comments
@qxv1612 Your fix makes sense. If you are willing, please feel free to send a PR with the fix. Otherwise, we will look into it later. Thanks! |
Hello @sobychacko, A local build currently fails in KafkaBinderTests, but I expect its related to my local env settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
about this code snippet starting at AbstractKafkaStreamsBinderProcessor:627 (version 4.1.0):
"consumed" is an Consumed-instance which is part of kafka-streams.
In kafka-streams 3.6.1 a call to consumed.withTimestampExtractor() changes the existing instance.
Since kafka-streams 3.7.0 the same call creates a new instance of "Consumed", but the code above ignores this new instance.
In the end, the timestampExtractor is not used at all since kafka 3.7.0.
Same for "consumed.withName" a couple of lines below.
IMHO this is a big change in kafka-streams inside a minor version change.
To fix this anyway the code above might be changed to
Regards,
Ralf
The text was updated successfully, but these errors were encountered: