-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata entries disc-count and tracks-count is not saved to metadata for opus files #2135
Comments
fixed everything you mentioned aside for
User comment frames have a description, like TXXX, and also a three letter ISO language code in the ‘lang’ attribute. |
Wouldn't it be more appropriate to store the youtube link in I am also not sure how multiple artists are handled currently in #2141 , last time I checked |
I've decided to use Comment tag so that users would have easier access to the link used for downloading to check whether the correct song was downloaded. WOAS is already used for the Spotify link.
There's not really an artists tag, each audio format has different structure. Artist tag stores them all |
Oh didn't know that, I am using Picard to tag my library and that's they use |
I actually already improvised a python script that puts
|
System OS
Linux
Python Version
3.11 (CPython)
Install Source
pip / PyPi
Install version / commit hash
v4.2.5
Expected Behavior vs Actual Behavior
Actual behaviour
When downloading opus files with
spotdl --bitrate disable --format opus [url]
, thedisc-count
andtrack-count
metadata tags are not written to the file, while for mp3's they are.Furthermore,
track-number
entries for opus files are prefixed by a '0', while for mp3's they are not.The download link is written in a
Comment
field for opus, while it is written in aComment[XXX]
field for mp3s.Expected behaviour
Metadata is supposed to be consistent for all formats. Opus files are expected to receive all the metadata that mp3 get, including
disc-count
andtrack-count
.track-number
tags are expected to be plain without prefixed '0' (contrary to when writing them to filenames where it indeed makes sense). The download link is expected to be written toComment
field for both opus and mp3.Steps to reproduce - Ensure to include actual links!
spotdl --bitrate disable --format opus https://open.spotify.com/track/0m7mTaFGMiKI3rBJpYknip?si=be48a256aacf4d23
spotdl --format mp3 https://open.spotify.com/track/0m7mTaFGMiKI3rBJpYknip?si=be48a256aacf4d23
Traceback
Other details
Difference in tags between opus and mp3 from the same source.
The text was updated successfully, but these errors were encountered: