Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

units prop on Base misaligned with speckle-sharp #281

Closed
JR-Morgan opened this issue Jun 7, 2023 · 1 comment
Closed

units prop on Base misaligned with speckle-sharp #281

JR-Morgan opened this issue Jun 7, 2023 · 1 comment
Assignees
@JR-Morgan
Labels
bug Something isn't working

Comments

@JR-Morgan
Copy link
Member

JR-Morgan commented Jun 7, 2023 •
edited
Loading

Misaligned units property on Base

In SpecklePY Base contains a units property
In Sharp, units is only used for geometry and primitives.

In py, this leads to confusing object json, where many non-geometry objects have a none units property. Including DataChunk objects`s 🤦‍♂️
@JR-Morgan JR-Morgan added the bug Something isn't working label Jun 7, 2023
@JR-Morgan JR-Morgan self-assigned this Jun 7, 2023
@JR-Morgan JR-Morgan linked a pull request Sep 4, 2023 that will close this issue
allow string units #290
Merged
6 tasks
@JR-Morgan JR-Morgan removed a link to a pull request Sep 4, 2023
allow string units #290
Merged
6 tasks
@JR-Morgan JR-Morgan mentioned this issue Sep 4, 2023
Merged
6 tasks
@bimgeek
Copy link

bimgeek commented Dec 15, 2023

Closing this ticket as we are moving to Jira to reduce noise. You can access it there.

@bimgeek bimgeek closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JR-Morgan JR-Morgan

Labels
bug Something isn't working
Projects
No open projects
Connectors Delivery 🔌
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JR-Morgan @bimgeek