Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing upgrade steps #218

Merged
merged 3 commits into from
May 11, 2023

Conversation

ashleyshenton
Copy link
Contributor

This PR attempts to resolve #217

Technically speaking, just the changes to the upgrade guide are needed. I have added a separate commit for removing the now unnecessary index from the stub migration for the reasons I detail in the linked issue.

I don't think this qualifies as a breaking change, but I can remove that commit if you'd prefer to retain both indexes. I can also remove this line from the example migration in the UPDGRADING.md.

@rubenvanassche rubenvanassche merged commit 52a2d65 into spatie:main May 11, 2023
@rubenvanassche
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v3 Upgrade Guide Missing Steps
2 participants