Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php artisan ray:clean doesn't cleanup everythign #332

Closed
sandersjj opened this issue Feb 11, 2024 · 2 comments
Closed

php artisan ray:clean doesn't cleanup everythign #332

sandersjj opened this issue Feb 11, 2024 · 2 comments
Assignees

Comments

@sandersjj
Copy link
Collaborator

Describe the bug
I had this piece of code still in my repo after running php artisan ray:clean:

     return Product::select('id', DB::raw("CONCAT(IF(available, '', 'NML-'), item_code, ' - ', item_description) as concatenated_value"))
                        ->where('brand_id', $brandId)
                        ->having('concatenated_value', 'like', "%{$search}%")
                        ->limit(25)
                        ->pluck('concatenated_value', 'id')
                        ->ray()
                        ->toArray();
                })

**Versions**
Version of the app: 2.7.5 
version of spatie/ray: 1.41.1

PHP version:8.2.15
Laravel version:10.43.0

**To Reproduce**
Steps to reproduce the behavior:
See above.

**Expected behavior**
I would expect ray() to be gone from the codebase after running the above command. 

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Desktop (please complete the following information):**
 - OS: Mac OS.
 - Version Sanoma 14.3
 
@timvandijck timvandijck self-assigned this Feb 16, 2024
@timvandijck
Copy link
Member

@sandersjj this indeed seems to be a case we haven't quite covered yet. I'm going to close this issue though and keep track in the main Ray repo as that's where we will implement the solution: spatie/ray#889

Thank you for sharing this example of the issue!

@sandersjj
Copy link
Collaborator Author

Thank you @timvandijck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants