Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optim_safe does not say enough when an error happens #108

Open
alexgenin opened this issue Mar 7, 2022 · 0 comments
Open

optim_safe does not say enough when an error happens #108

alexgenin opened this issue Mar 7, 2022 · 0 comments

Comments

@alexgenin
Copy link
Collaborator

Distribution-fitting is done using optim_safe() (in https://github.com/spatial-ews/spatialwarnings/blob/master/R/fitpsd.R#L24), which is there to catch errors when the optimization goes into undefined ranges, among other things. However, it tends to hide errors that are meaningful and are not due to convergence issues, e.g. today after an upgrade:

Error in dyn.load(file, DLLpath = DLLpath, ...) : \n  unable to load shared object '/home/alex/R/x86_64-pc-linux-gnu-library/4.1/gsl/libs/gsl.so':\n  libgsl.so.25: cannot open shared object file: No such file or directory\n

In those cases, it will return NA/NaN-like objects for no good reason. There should be a way to stop when those errors occur (or at least show a warning), and not hide them as if they were convergence-related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant