Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SegmentList usage #35

Open
jotaylor opened this issue Jun 9, 2022 · 1 comment
Open

Update SegmentList usage #35

jotaylor opened this issue Jun 9, 2022 · 1 comment
Assignees
@jotaylor
Labels
enhancement New feature or request hlsp timeseries Relates to timeseries products

Comments

@jotaylor
Copy link
Collaborator

jotaylor commented Jun 9, 2022

Instead of explicitly calling out STIS and COS, you can use the generic SegmentList since no data is actually being coadded together here.
https://github.com/spacetelescope/ullyses/blob/main/ullyses/timeseries.py#L192
@jotaylor jotaylor self-assigned this Jun 9, 2022
@jotaylor jotaylor added enhancement New feature or request hlsp timeseries Relates to timeseries products labels Jun 9, 2022
@jotaylor jotaylor mentioned this issue Jun 9, 2022
Merged
@jotaylor
Copy link
Collaborator Author

I believe the original intention here was to abstract away the instrument-specific usage of child SegmentList classes in timeseries. This may be possible, but would require testing. This ticket will be left open for now, but this is an enhancement to generalize the code, not a necessity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jotaylor jotaylor

Labels
enhancement New feature or request hlsp timeseries Relates to timeseries products
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jotaylor