Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viper won't override nested config with cli flags #245

Closed
2 tasks
y0sher opened this issue Nov 13, 2018 · 1 comment
Closed
2 tasks

Viper won't override nested config with cli flags #245

y0sher opened this issue Nov 13, 2018 · 1 comment

Comments

@y0sher
Copy link
Contributor

y0sher commented Nov 13, 2018

Using viper we load config from a toml file. we wan't the default config to be loaded, then overridden by a config file if exists, then overridden by the cli flags.

viper claim this to work after spf13/viper#195

couldn't get it working for us so I had to add some patch in #238 .

How to fix ?

  • Use normal viper methods to load cli flags after config
  • write tests to show that the flow described above works.
@y0sher
Copy link
Contributor Author

y0sher commented Jan 9, 2020

we have an ugly fix for it, though viper claimed to fix the problem and I saw some more elegant fixes to it on github.

@noamnelke noamnelke added this to the TN-1.0 milestone Jan 28, 2020
@avive avive modified the milestones: TN1, TN2 Feb 9, 2020
@moshababo moshababo removed this from the TN_GC milestone Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants