Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workers: PHPStan shows file have multiple errors #503

Open
oyeaussie opened this issue Jul 6, 2024 · 0 comments
Open

Workers: PHPStan shows file have multiple errors #503

oyeaussie opened this issue Jul 6, 2024 · 0 comments
Assignees
@oyeaussie
Labels
bug Something is not working Needs Further Investigation Get ready for sleepless nights, unlimited coffee to find issue was a missing comma P2 If not fixed, how will I sleep tonight
Milestone
0.0.0-rc.7

Comments

@oyeaussie
Copy link
Contributor

PHPStan found the following:

  Line   system/Base/Providers/BasepackagesServiceProvider/Packages/Workers.php  
 ------ ------------------------------------------------------------------------ 
  639    Undefined variable: $day                                                
  649    Undefined variable: $month                                              
  770    Undefined variable: $day                                                
  790    Undefined variable: $month                                              
  819    Undefined variable: $task                                               
  825    Undefined variable: $task                                               
  833    Undefined variable: $task                                               
  841    Undefined variable: $task                                               
  849    Undefined variable: $task                                               
  858    Undefined variable: $task                                               
  860    Undefined variable: $day                                                
  868    Undefined variable: $task                                               
  870    Undefined variable: $month                                              
 ------ ------------------------------------------------------------------------ ```

######## Issue imported from Gitea ########
# Details
Gitea Issue ID : 572
State : open
Created : 2024-06-09T13:40:40+10:00
# Issue Description
PHPStan found the following:

``` ------ ------------------------------------------------------------------------ 
  Line   system/Base/Providers/BasepackagesServiceProvider/Packages/Workers.php  
 ------ ------------------------------------------------------------------------ 
  639    Undefined variable: $day                                                
  649    Undefined variable: $month                                              
  770    Undefined variable: $day                                                
  790    Undefined variable: $month                                              
  819    Undefined variable: $task                                               
  825    Undefined variable: $task                                               
  833    Undefined variable: $task                                               
  841    Undefined variable: $task                                               
  849    Undefined variable: $task                                               
  858    Undefined variable: $task                                               
  860    Undefined variable: $day                                                
  868    Undefined variable: $task                                               
  870    Undefined variable: $month                                              
 ------ ------------------------------------------------------------------------ ```

# Timeline
Milestone : Added 0.0.0-rc.4 on 2024-06-09T13:40:40+10:00.
Label : Added bug on 2024-06-09T13:40:40+10:00.
Label : Added P2 on 2024-06-09T13:40:40+10:00.
Label : Added Needs Further Investigation on 2024-06-09T14:33:40+10:00.
@oyeaussie oyeaussie added bug Something is not working Needs Further Investigation Get ready for sleepless nights, unlimited coffee to find issue was a missing comma P2 If not fixed, how will I sleep tonight labels Jul 6, 2024
@oyeaussie oyeaussie self-assigned this Jul 6, 2024
@oyeaussie oyeaussie added this to the 0.0.0-rc.6 milestone Jul 7, 2024
@oyeaussie oyeaussie changed the title Workers file have multiple errors Workers: PHPStan shows file have multiple errors Jul 9, 2024
@oyeaussie oyeaussie modified the milestones: 0.0.0-rc.6, 0.0.0-rc.7 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyeaussie oyeaussie

Labels
bug Something is not working Needs Further Investigation Get ready for sleepless nights, unlimited coffee to find issue was a missing comma P2 If not fixed, how will I sleep tonight
Projects
None yet
Milestone
0.0.0-rc.7
Development

No branches or pull requests
1 participant
@oyeaussie