Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Template Default: Change document.ready to window.onload #499

Open
oyeaussie opened this issue Jul 6, 2024 · 0 comments
Open

Core Template Default: Change document.ready to window.onload #499

oyeaussie opened this issue Jul 6, 2024 · 0 comments
Assignees
Labels
P3 I will get to this in a week or a month, bribe me to prioritise task Perform a Task

Comments

@oyeaussie
Copy link
Contributor

window.on('load' occurs after document.ready.

If you want to load something in the end, use window.on('load'

######## Issue imported from Gitea ########

Details

Gitea Issue ID : 568
State : open
Created : 2024-05-26T13:27:03+10:00

Issue Description

window.on('load' occurs after document.ready.

If you want to load something in the end, use window.on('load'

Timeline

Label : Added task on 2024-05-26T13:27:03+10:00.
Label : Added P3 on 2024-05-26T13:27:03+10:00.
Commented : from observation, some functions need onload and some need document ready. This was when we reload the page, we hit document ready and when we access via BazContentLoader, we hit window.onload.

Test both behaviors.

@oyeaussie oyeaussie added P3 I will get to this in a week or a month, bribe me to prioritise task Perform a Task labels Jul 6, 2024
@oyeaussie oyeaussie self-assigned this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 I will get to this in a week or a month, bribe me to prioritise task Perform a Task
Projects
None yet
Development

No branches or pull requests

1 participant