Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Payment failed" error messages #63265

Open
vdavid opened this issue Jun 14, 2024 · 2 comments
Open

Improve "Payment failed" error messages #63265

vdavid opened this issue Jun 14, 2024 · 2 comments

Comments

@vdavid
Copy link
Contributor

vdavid commented Jun 14, 2024

They all look like this now:

Payment error message

For each of these card types: https://docs.stripe.com/testing#declined-payments and others on the page, we want to provide informative error messages instead of "We couldn't create the Stripe token. This is what happened: Error: Request to Cody Pro API failed: Bad Gateway".

@vdavid
Copy link
Contributor Author

vdavid commented Jun 14, 2024

Oh, actually, it was my mistake, my DB was in the wrong state. We actually display the failure-specific error messages:

Image

The problem is that in case of a payment failure, we create the user and team, but fail to create the subscription and don't roll back the user+team creation steps, so the DB ends up in a broken state.
Created issue for that: https://github.com/sourcegraph/self-serve-cody/issues/877.

I'll still leave the issue open, though, because the error message could be clearer and more in line with the rest of the design.

@vdavid
Copy link
Contributor Author

vdavid commented Jun 20, 2024

They get even nastier:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant