Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permalinks to items in Perforce depots #50488

Open
peterguy opened this issue Apr 7, 2023 · 1 comment
Open

Fix permalinks to items in Perforce depots #50488

peterguy opened this issue Apr 7, 2023 · 1 comment
Assignees
@indradhanush
Labels
first-class-perforce Issues associated with make Perforce a first class code host perforce-changelists Issues around Changelist Ids for Perforce depots
Milestone
First-class Perfo...

Comments

@peterguy
Copy link
Contributor

peterguy commented Apr 7, 2023 •
edited
Loading

p4-fusion calculates Git commit hashes while syncing depots, but if certain things in the depot change and the depot is re-synced, (known issue: Perforce users being deactivated, thus losing access to the email address), the commit hashes could change, destroying permalinks because permalinks use commit hashes. Either address the instability of commit hashes generated by p4-fusion, or switch to using changelist and/or file revisions in permalinks for Perforce depots.
@peterguy peterguy mentioned this issue Apr 7, 2023
Closed
4 tasks
@peterguy peterguy added the first-class-perforce Issues associated with make Perforce a first class code host label Apr 7, 2023
@sourcegraph-bot-devx sourcegraph-bot-devx mentioned this issue Apr 7, 2023
Open
55 tasks
@peterguy
Copy link
Contributor Author

After #40330, this issue will add permalink support.

@peterguy peterguy added the perforce-changelists Issues around Changelist Ids for Perforce depots label May 5, 2023
@sourcegraph-bot-devx sourcegraph-bot-devx mentioned this issue May 5, 2023
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@indradhanush indradhanush

Labels
first-class-perforce Issues associated with make Perforce a first class code host perforce-changelists Issues around Changelist Ids for Perforce depots
Projects
None yet
Milestone
First-class Perforce QoL and Bugfixes
Development

No branches or pull requests
2 participants
@peterguy @indradhanush