Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

域名中带有英文减号时无法生成证书 #7

Closed
he-sb opened this issue Nov 12, 2022 · 5 comments
Closed

域名中带有英文减号时无法生成证书 #7

he-sb opened this issue Nov 12, 2022 · 5 comments

Comments

@he-sb
Copy link
Contributor

he-sb commented Nov 12, 2022

当指定参数 --CERT_DNS=pve.he-sb.home ,即运行容器的命令为

docker run --rm -it -v `pwd`/ssl:/ssl soulteary/certs-maker "--CERT_DNS=pve.he.home"

时,会报错:

running soulteary/certs-maker v2.4.2
wrong domains, set to default value: lab.com,*.lab.com,*.data.lab.com

实际生成的是域名为 lab.com 的证书

@he-sb
Copy link
Contributor Author

he-sb commented Nov 12, 2022

尝试了使用 -e CERT_DNS="pve.he-sb.home" ,问题依旧。完整命令:

docker run --rm -it -v `pwd`/ssl:/ssl -e CERT_DNS="pve.he-sb.home" soulteary/certs-maker

@soulteary
Copy link
Owner

感谢反馈,@he-sb 试试看 v2.4.3 版本~

@he-sb
Copy link
Contributor Author

he-sb commented Nov 15, 2022

@soulteary

v2.4.3 版本生成的证书文件名,域名中减号前面的部分,包括减号自身,都不见了。。😂

比如命令为

docker run --rm -it -v `pwd`/ssl:/ssl soulteary/certs-maker "--CERT_DNS=pve.he-sb.home"

docker run --rm -it -v `pwd`/ssl:/ssl -e CERT_DNS="pve.he-sb.home" soulteary/certs-maker

时,生成的证书文件名均为:

sb.home.conf  sb.home.crt  sb.home.key

证书中的 DNS 属性中的域名是没问题的,确实是 pve.he-sb.home 没问题,只有生成的文件名有问题

@soulteary
Copy link
Owner

@soulteary

v2.4.3 版本生成的证书文件名,域名中减号前面的部分,包括减号自身,都不见了。。😂

比如命令为

docker run --rm -it -v `pwd`/ssl:/ssl soulteary/certs-maker "--CERT_DNS=pve.he-sb.home"

docker run --rm -it -v `pwd`/ssl:/ssl -e CERT_DNS="pve.he-sb.home" soulteary/certs-maker

时,生成的证书文件名均为:

sb.home.conf  sb.home.crt  sb.home.key

证书中的 DNS 属性中的域名是没问题的,确实是 pve.he-sb.home 没问题,只有生成的文件名有问题

@he-sb fixed

@he-sb
Copy link
Contributor Author

he-sb commented Nov 16, 2022

@soulteary
v2.4.3 版本生成的证书文件名,域名中减号前面的部分,包括减号自身,都不见了。。😂
比如命令为

docker run --rm -it -v `pwd`/ssl:/ssl soulteary/certs-maker "--CERT_DNS=pve.he-sb.home"

docker run --rm -it -v `pwd`/ssl:/ssl -e CERT_DNS="pve.he-sb.home" soulteary/certs-maker

时,生成的证书文件名均为:

sb.home.conf  sb.home.crt  sb.home.key

证书中的 DNS 属性中的域名是没问题的,确实是 pve.he-sb.home 没问题,只有生成的文件名有问题

@he-sb fixed

很赞,没问题啦~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants