Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI Gater: floor is not floor #21

Closed
sophiapoirier opened this issue Oct 6, 2020 · 0 comments
Closed

MIDI Gater: floor is not floor #21

sophiapoirier opened this issue Oct 6, 2020 · 0 comments
Assignees

Comments

@sophiapoirier
Copy link
Owner

Should it be floor? Probably. What the "floor" parameter currently controls is what Rez Synth calls "between gain", aka the input audio level added between MIDI notes sounding. But it is not an actual input audio level floor in the sense of being a minimum amount of input signal always present, with gate-on adding more. Especially if you have longer attack or release and a higher floor level, it becomes very obviously not floor because the attack suddenly silences the "floor" audio and then slowly fades up to sustain level, while the release slowly decays to silence only to suddenly jump to floor level at the end of that decay. I think probably floor should be floor, but if not, at least then it should not be named "floor" but rather something accurate (like "between gain").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant