Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Increase contrast #110

Open
dwettstein opened this issue Apr 16, 2021 · 1 comment
Open

Suggestion: Increase contrast #110

dwettstein opened this issue Apr 16, 2021 · 1 comment

Comments

@dwettstein
Copy link

dwettstein commented Apr 16, 2021

I really like the onehalf themes (both light and dark), however, IMHO the contrast could be better, especially when using the light theme.
What do you guys think of increasing the contrast?

  • Current contrast of dark theme:
    image
  • Increased contrast of dark theme:
    image
  • Current contrast of light theme:
    image
  • Increased contrast of light theme:
    image

Check yourself: https://contrast-ratio.com/

Note: According to WCAG, the contrast ratio can range from 1 (lowest) to 21 (highest).

@BigBrotherJu
Copy link

Yeah, I totally agree. I'm using OneHalf Light, and the colors are really pleasing to the eye. But the contrasts are very low. It's sometimes hard to differentiate red or green from the white background. However, changing colors to provide more contrast while maintaining the same vibe requires a deep understanding of colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants