-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json and Yang Model supports #20826
Open
mlok-nokia
wants to merge
5
commits into
sonic-net:master
Choose a base branch
from
mlok-nokia:asic_sensor_pulling_config
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json and Yang Model supports #20826
mlok-nokia
wants to merge
5
commits into
sonic-net:master
from
mlok-nokia:asic_sensor_pulling_config
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlok-nokia
force-pushed
the
asic_sensor_pulling_config
branch
2 times, most recently
from
November 18, 2024 19:05
fba67c0
to
b26025d
Compare
…n the platform.json Signed-off-by: mlok <[email protected]>
mlok-nokia
changed the title
[asic_sensors] Generate the aisc_sensors pulling configuration based on the platform.json
[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json
Nov 18, 2024
@judyjoseph Please review this asic-sensors PR. Thanks |
mlok-nokia
changed the title
[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json
[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json and Yang Model supports
Nov 21, 2024
…figuration Signed-off-by: mlok <[email protected]>
Signed-off-by: mlok <[email protected]>
…r Nokia platforms Platforms: arm64-nokia_ixs7215_52xb-r0 x86_64-nokia_ixr7220_h4-r0 x86_64-nokia_ixr7220_h4_32d-r0 x86_64-nokia_ixr7220_h5_64d-r0 Signed-off-by: mlok <[email protected]>
mlok-nokia
force-pushed
the
asic_sensor_pulling_config
branch
2 times, most recently
from
November 21, 2024 22:10
7c56970
to
f991ffc
Compare
Signed-off-by: mlok <[email protected]>
@arlakshm This Includes the Yang Model for ASIC_SENSORS configuration. Please review it |
judyjoseph
reviewed
Nov 22, 2024
container ASIC_SENSORS_POLLER_STATUS { | ||
leaf admin_status { | ||
type poller_status; | ||
default "enable"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep the default as "enable" ?
Minor comments LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
For any platform which supports the asic_sensors pulling, it requires the configuration files (config_db#.json) contain the following configuration to trigger the system to poll the ASIC sensors temperature. Fixes https://github.com/Nokia-ION/ndk/issues/48
Adding Yang model support to fixes #20633
Work item tracking
How I did it
Notice: For all platforms which support the asic_sensors polling requires to add the following definition to the device data platform.json file
Also add Yang Model support the ASIC_SENSORS configuration. INcluding YangModel UT.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)