New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#Interval incorrectly builds interval #44

Closed

qr8r opened this issue Nov 10, 2017 · 0 comments

Labels

Contributor

qr8r commented Nov 10, 2017

https://github.com/solidusio-contrib/solidus_subscriptions/blob/master/app/models/solidus_subscriptions/interval.rb#L20

[7] pry(main)> ActiveSupport::Duration.new(1, { months: 1 }).to_i
=> 1
[8] pry(main)> ActiveSupport::Duration.new(1, { months: 1 }).seconds
=> 1 second
[9] pry(main)> ActiveSupport::Duration.new(1, { months: 1 }) == 1.months
=> false

Thanks @alepore for reporting

The text was updated successfully, but these errors were encountered:

qr8r added the bug label

qr8r closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment