Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow guest orders to manage subscriptions via API #279

Closed
elia opened this issue Jan 13, 2023 · 3 comments · Fixed by #282
Closed

Allow guest orders to manage subscriptions via API #279

elia opened this issue Jan 13, 2023 · 3 comments · Fixed by #282
Assignees

Comments

@elia
Copy link
Member

elia commented Jan 13, 2023

It should be possible to create and edit subscriptions (e.g. changing intervals(quantity) via API calls.
Currently, though, it seems like an API token is required (which is not available for guest checkouts).

@chrean chrean changed the title Handling guest orders with subscriptions via API Allow guest orders to manage subscriptions via API Jan 13, 2023
@kennyadsl
Copy link
Member

Started to look into this ticket, and would like to have more details about this request.

I think that guest users can create and order with a subscribable line item which will end up creating a subscription. Isn't that enough to allow guest users to checkout and create a line item?

@elia
Copy link
Member Author

elia commented Feb 7, 2023

This issue was reported by a 3rd party user, so I don't have the complete details, but looking at the request specs for the solidus_api controllers we're always providing the Authorization header with the spree_api_key:

https://github.com/solidusio/solidus_subscriptions/tree/master/spec/requests/api/v1

@kennyadsl if the api controllers we have already support guest operations maybe we should just add specs that would both ensure it keeps working and show how to do it.

Please let me know if there's anything else that I can help clarifying, in case it's needed I can reach out to the users that reported the issue.

@kennyadsl
Copy link
Member

kennyadsl commented Feb 13, 2023

This is related to the possibility to edit subscribable line items (e.g. changing intervals(quantity) via API calls, after they have already been added to the cart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants