You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If there are issues with order finalization, leaving the order incomplete (as described here), a subscription can still be created depending on when the failure happened. Additionally, it's worth noting that calling the order#finalize! method is discouraged and deprecated as of solidusio/solidus#4482.
While we shouldn't expect issues with finalize!, it would be safer to avoid decorating this critical Solidus flow by moving the subscription creation to a background job triggered by an order finalization subscriber.
If there are issues with order finalization, leaving the order incomplete (as described here), a subscription can still be created depending on when the failure happened. Additionally, it's worth noting that calling the
order#finalize!
method is discouraged and deprecated as of solidusio/solidus#4482.While we shouldn't expect issues with
finalize!
, it would be safer to avoid decorating this critical Solidus flow by moving the subscription creation to a background job triggered by an order finalization subscriber.Decorator that generates subscriptions: https://github.com/solidusio-contrib/solidus_subscriptions/blob/master/app/decorators/models/solidus_subscriptions/spree/order/finalize_creates_subscriptions.rb
The text was updated successfully, but these errors were encountered: