Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate payment source ownership #208

Closed
aldesantis opened this issue Mar 4, 2021 · 0 comments · Fixed by #214
Closed

Validate payment source ownership #208

aldesantis opened this issue Mar 4, 2021 · 0 comments · Fixed by #214
Assignees
@ChristianRimondi
Labels
enhancement Improves an existing feature.
Projects
Project
Milestone
1.0.0

Comments

@aldesantis
Copy link
Member

We should validate that the payment source used for the subscription (if specified explicitly) is owned by the same user that is on the subscription, as done in the Solidus wallet. This will help prevent any bugs when the payment source for a subscription is accidentally set to another user's payment source.
@aldesantis aldesantis added the enhancement Improves an existing feature. label Mar 4, 2021
@aldesantis aldesantis added this to To do in Project Mar 5, 2021
@aldesantis aldesantis added this to the 1.0.0 milestone Mar 5, 2021
@ChristianRimondi ChristianRimondi self-assigned this Mar 5, 2021
@ChristianRimondi ChristianRimondi moved this from To do to In progress in Project Mar 5, 2021
@ChristianRimondi ChristianRimondi mentioned this issue Mar 26, 2021
Merged
@ChristianRimondi ChristianRimondi moved this from In progress to Ready for review in Project Mar 26, 2021
Project automation moved this from Ready for review to Done Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristianRimondi ChristianRimondi

Labels
enhancement Improves an existing feature.
Projects
No open projects
Project
Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Validate payment_source ownership on the subscription solidusio/solidus_subscriptions
2 participants
@ChristianRimondi @aldesantis