Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default currency when creating subscription from admin panel #207

Closed
luca-landa opened this issue Feb 26, 2021 · 0 comments · Fixed by #210
Closed

Set default currency when creating subscription from admin panel #207

luca-landa opened this issue Feb 26, 2021 · 0 comments · Fixed by #210
Assignees
@luca-landa
Labels
bug Describes or fixes a bug.
Projects
Project
Milestone
1.0.0

Comments

@luca-landa
Copy link
Contributor

After #198 the subscription creation from admin panel breaks, because it does not have a currency value.

It should probably be set to the default Spree::Config currency value, like Spree::Order currently does.
@luca-landa luca-landa self-assigned this Feb 26, 2021
@luca-landa luca-landa added this to To do in Project via automation Feb 26, 2021
@luca-landa luca-landa moved this from To do to In progress in Project Feb 26, 2021
@luca-landa luca-landa added the bug Describes or fixes a bug. label Feb 26, 2021
@aldesantis aldesantis added this to the 1.0.0 milestone Mar 5, 2021
@luca-landa luca-landa mentioned this issue Mar 5, 2021
Merged
@luca-landa luca-landa moved this from In progress to Ready for review in Project Mar 5, 2021
@ChristianRimondi ChristianRimondi moved this from Ready for review to Review approved in Project Mar 12, 2021
Project automation moved this from Review approved to Done Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luca-landa luca-landa

Labels
bug Describes or fixes a bug.
Projects
No open projects
Project
Done
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Set default config currency to subscription solidusio/solidus_subscriptions
2 participants
@aldesantis @luca-landa