Cleanup the duplicated fields on subscription creation #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blocknotes
force-pushed
the
mr/cleanup-duplicated-fields-on-order-finalize
branch
from
9cd46dc
to
9858424
Compare
igorbp
suggested changes
Feb 12, 2021
There was a problem hiding this comment.
Hey @blocknotes. Thank you for the changes :)
I've made a few suggestions for the tests. Let me know what do you think.
ChristianRimondi
approved these changes
Feb 19, 2021
igorbp
approved these changes
Feb 19, 2021
aldesantis
deleted the
mr/cleanup-duplicated-fields-on-order-finalize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm going to implement the second solution proposed in the issue because I think that if those fields on the source have completed their goal and we don't need them anymore on the line items it is conceptually good to move them in the subscription. And it also seems to me the way less prone to unexpected side effects/bugs (keep it simple).
Closes #114.