Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redundancy of address.state_name and address.state.name #57

Closed
mdesantis opened this issue Dec 6, 2019 · 1 comment
Closed

Fix redundancy of address.state_name and address.state.name #57

mdesantis opened this issue Dec 6, 2019 · 1 comment
Labels
wontfix This will not be worked on
Projects
solidus_graphql_api

Comments

@mdesantis
Copy link

mdesantis commented Dec 6, 2019 •
edited
Loading

Currently, the Address type has both a stateName string field and a state object with a name field. In Solidus, only one of them has a value.

Investigate whether or not it is possible to remove such redundancy. GraphQL union types come to mind.
@mdesantis mdesantis changed the title Investigate redundancy of address.state_name and address.state.name Fix redundancy of address.state_name and address.state.name Dec 6, 2019
@ChristianRimondi ChristianRimondi added this to Backlog in solidus_graphql_api via automation Mar 6, 2020
@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 7, 2020
@stale stale bot closed this as completed Apr 14, 2020
solidus_graphql_api automation moved this from Backlog to Done Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
solidus_graphql_api
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdesantis