-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Taxons to Products + HasManyThrough BatchLoader #148
Labels
wontfix
This will not be worked on
Comments
Hi @fhirzall, sorry for the late response but it was a busy start of the year. The first solution with the |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
Thanks for the great work on this gem. I noticed while adding a
taxons
field toProduct
following the example here:https://github.com/solidusio-contrib/solidus_graphql_api#adding-a-new-field
BatchLoader::HasManyThrough
ends up resolving the query and produces duplicate taxons for each product. Here's a sample query that's generated with the joins on some test data:This happens here in
BatchLoader::HasManyThrough
:We have two potential solutions
distinct
when batchingHasManyThrough
associations to prevent duplicate recordsThoughts? Please let me know if I'm missing something - happy to send in a PR once this is discussed.
Thanks!
The text was updated successfully, but these errors were encountered: