Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename or extract the solidus executable #46

Open
elia opened this issue Jan 3, 2020 · 2 comments
Open

Rename or extract the solidus executable #46

elia opened this issue Jan 3, 2020 · 2 comments

Comments

@elia
Copy link
Member

elia commented Jan 3, 2020

Using solidus as the executable name makes little sense for a gem called solidus_dev_support, we should establish a base solidus command within core and allow it to be extended by the ecosystem.

solidus_dev_support can keep using the extension namespace but should deprecate defining the executable.

A possible alternative could be to switch to solidus-extension with commands such as:

  • generate for new extensions
  • update similar to rails app:update
  • release
@elia elia added the enhancement Improves an existing feature. label Jan 3, 2020
@elia elia self-assigned this Jan 7, 2020
@aldesantis
Copy link
Member

Worth adding that we also discussed with @elia the possibility of moving the solidus executable to solidus_core and simply adding the extension subcommand in solidus_dev_support. This seems the cleanest route, since it gives us the ability to have commands such as solidus extension generate and solidus extension update that make a lot of sense semantically.

@aldesantis aldesantis changed the title Rethink the executable Rename or move the executable Jan 10, 2020
@aldesantis aldesantis changed the title Rename or move the executable Rename or extract the executable Jan 10, 2020
@aldesantis aldesantis changed the title Rename or extract the executable Rename or extract the solidus executable Jan 10, 2020
@elia
Copy link
Member Author

elia commented Jan 10, 2020

@aldesantis 💯

The tricky part about that is supporting older versions, so maybe we could resurrect solidus_cmd for that purpose, moving it to thor and leaving out the extension generation… then reintegrating it in side solidus_core with the next release.

@aldesantis aldesantis removed the enhancement Improves an existing feature. label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants