Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create override generator #102

Open
aldesantis opened this issue May 16, 2020 · 5 comments
Open

Create override generator #102

aldesantis opened this issue May 16, 2020 · 5 comments

Comments

@aldesantis
Copy link
Member

It would be useful to have an override generator that creates the right placeholder module in the right path.

@peterberkenbosch
Copy link
Contributor

peterberkenbosch commented May 21, 2020

I like this idea, were you thinking about something like this:

PBC ~/code/my_solidus_extention # ./bin/override Spree::Product MyDecorator
  • adds override file my_decorator.rb with mod..prepend on Spree::Product
  • adds my_decorator_spec.rb
  • ?

@aldesantis
Copy link
Member Author

@peterberkenbosch correct, that was more or less the idea! Instead of having a bin/override though, we can just use the existing CLI.

@peterberkenbosch
Copy link
Contributor

Should we still call them decorators? There has been, or is a discussion going on this. we could call it monkey_patch? I do not have a very strong opinion on this, but I know others might.

@aldesantis
Copy link
Member Author

I like decorators, although recently we have started calling them prependers. In fact, I think we should hold off on this one for a while because we're still considering whether Prependers should become a standard in the Solidus world.

@elia elia added the blocked Blocked by external factors. label May 22, 2020
@peterberkenbosch
Copy link
Contributor

I like prependers! Looking at that repo linked again too. Will keep this on hold.

@aldesantis aldesantis removed the blocked Blocked by external factors. label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants