[v4.0] Dummy App generator: Use db var instead of ENV var #5625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of lines before this change, we already normalize `ENV['db']`. We lose that work by relying on the raw ENV var here. (cherry picked from commit 1411fc9)
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.0 #5625 +/- ##
=======================================
Coverage 88.62% 88.62%
=======================================
Files 562 562
Lines 13877 13877
=======================================
Hits 12298 12298
Misses 1579 1579 ☔ View full report in Codecov by Sentry. |
adammathys
approved these changes
Jan 24, 2024
spaghetticode
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
v4.2tov4.0:Questions ?
Please refer to the Backport tool documentation