Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Refactor index page settings: Ransack search and pagination #5546

Merged
merged 2 commits into from
Dec 12, 2023
Merged

[Admin] Refactor index page settings: Ransack search and pagination #5546

merged 2 commits into from
Dec 12, 2023

Conversation

rainerdema
Copy link
Contributor

Summary

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@rainerdema
Remove the per_page preferences in Solidus admin configuration.
fbb75af 
This aligns index pages with the default `geared_pagination` gem 
settings:
15 items on page 1, 30 on page 2, 50 on page 3, and 100
from page 4 onwards.
@rainerdema
Move ransack search key to components
1375109 
Migrated Ransack search key from configuration preferences to components
in index pages, aligning with our component-based architecture.
@rainerdema rainerdema self-assigned this Dec 12, 2023
@rainerdema rainerdema marked this pull request as ready for review December 12, 2023 14:11
@rainerdema rainerdema requested a review from a team as a code owner December 12, 2023 14:11
@rainerdema rainerdema merged commit c4d62df into solidusio:main Dec 12, 2023
6 checks passed
@rainerdema rainerdema deleted the rainerd/admin/move-preferences-in-admin branch December 12, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elia elia elia approved these changes

Assignees

@rainerdema rainerdema

Labels
changelog:solidus_admin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rainerdema @elia