Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ui/thumbnail component #5431

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Add a ui/thumbnail component #5431

merged 1 commit into from
Oct 12, 2023

Conversation

elia
Copy link
Member

@elia elia commented Oct 11, 2023

Summary

image

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #5431 (4ceef99) into main (afc630e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5431   +/-   ##
=======================================
  Coverage   88.85%   88.86%           
=======================================
  Files         609      610    +1     
  Lines       14784    14791    +7     
=======================================
+ Hits        13137    13144    +7     
  Misses       1647     1647           
Files Coverage Δ
...mponents/solidus_admin/products/index/component.rb 86.84% <ø> (ø)
...components/solidus_admin/ui/thumbnail/component.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@elia elia marked this pull request as ready for review October 12, 2023 10:58
@elia elia requested a review from a team as a code owner October 12, 2023 10:58
Copy link
Contributor

@rainerdema rainerdema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@elia elia merged commit 7869560 into main Oct 12, 2023
11 checks passed
@elia elia deleted the elia/admin/thumbnail branch October 12, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants