Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible left nav #666

Closed
Mandily opened this issue Jan 7, 2016 · 12 comments
Closed

Collapsible left nav #666

Mandily opened this issue Jan 7, 2016 · 12 comments

Comments

@Mandily
Copy link
Contributor

Mandily commented Jan 7, 2016

We can gain some screen real estate for heavy content pages by introducing a collapsible left navigation. Users that are working on small screens can manually reduce the width of the menu, while users on bigger screens can simply ignore it and not be affected.

While the menu is collapsed, the icons will still be visible and link to their respective pages. All sub-navs will also be collapsed, but still accessible by hovering over the icon.

Clicking on the collapsed menu will un-collapse the menu so that the user has automatic access to child menu items.

Because some of the menus can bit longer and may even trigger a scrollbar on small screens, I've put the button at the top of the navigation instead of after the nav links.

collapsible-nav

Please let me know your thoughts in the comments below.

@tvdeyen
Copy link
Member

tvdeyen commented Jan 7, 2016

This would be a great addition. 👏

We need to assure, that the label of the menu item is visible while hovering over it. In current Spree 3 admin the label is not shown and therefore it's hard to guess what icon is the desired one.

monosnap 2016-01-08 00-25-23

@Mandily
Copy link
Contributor Author

Mandily commented Jan 7, 2016

That's a good point. I've run into that in other interfaces as well. Are you picturing a browser tooltip-like thing or something more like the UI of the sub nav flyout?

@tvdeyen
Copy link
Member

tvdeyen commented Jan 8, 2016

Like the fly out. We shouldn't introduce another visual for the main navigation. That could be confusing.

@sukhchander
Copy link

@tvdeyen @Mandily i've implemented the collapsed nav as well as hover. who is working on the implementation of the refactored admin? i'd like to contribute or should i just create a fork?

expanded:
screenshot 2015-12-22 11 28 24

collpased:
screenshot 2015-12-22 11 28 08

@tvdeyen
Copy link
Member

tvdeyen commented Jan 8, 2016

@sukhchander I guess @Sinetheta will do the implementation, but please feel free to send a PR. We are happy about every contribution.

How do you handled the missing label in collapsed menus? Your screenshot does not show how a hover state of a collapsed menu item will look like.

@Mandily
Copy link
Contributor Author

Mandily commented Jan 11, 2016

We've been chatting about this issue in the Slack #gui channel and it looks like we're leaning in favour of using a tooltip. It's the easiest to implement (some version of it was part of Spree) and seems the most intuitive out of our options.

I think the trick will be to play with it and get the right amount of delay on the hover. We'll also need to make sure that it's styled so that it's not confused with the sub-navigation.

@tvdeyen
Copy link
Member

tvdeyen commented Jan 11, 2016

A delay in UI can be problematic for important information like the main navi entries.

What if we let the tooltip point from top of the icon, so that the fly out does not interfere with it?

@Mandily
Copy link
Contributor Author

Mandily commented Jan 19, 2016

This was originally planned for the 1.2 release, but due to time constraints we'll be moving this to a future release.

@sukhchander
Copy link

sounds good

@Mandily
Copy link
Contributor Author

Mandily commented Apr 18, 2016

We've been on pause for this one for a while, but you should see some traction on this one in the next few weeks. We're still aiming to get this in for 1.3.

@Mandily
Copy link
Contributor Author

Mandily commented Apr 18, 2016

Had a quick chat with @Sinetheta to nail down the requirements for this.

  • Default open on large screens.
  • Default close on small screens.
  • Remember user preferences on the computer/device they're using.
  • Stays open/close until user changes the preference.
  • Label on collapsed nav items to appear on hover. Tooltip should look consistent with admin, but different from menu styles.

collapsible-nav-side-by-side

@gmacdougall
Copy link
Member

Closing due to staleness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants