Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Admin] Undefined destroy method call on non soft deletable Spree::Property #5576

Closed
tonxyx opened this issue Dec 29, 2023 · 0 comments · Fixed by #5577
Closed

[Admin] Undefined destroy method call on non soft deletable Spree::Property #5576

tonxyx opened this issue Dec 29, 2023 · 0 comments · Fixed by #5577

Comments

@tonxyx
Copy link
Contributor

tonxyx commented Dec 29, 2023 •
edited
Loading

Deletion of properties will fail with undefined method discard_all

Solidus Version: 4.3.0

To Reproduce

  1. Go to Solidus Admin
  2. Click on Products -> Properties
  3. Select all items or try with a single one
  4. Try to delete them with the Delete button - the app will fail

Current behavior
The application fails to delete Property records with undefined method discard_all

Expected behavior
Properties should be deleted with a success message popup.

Screenshots
Screenshot 2023-12-29 at 17 17 09

Desktop (please complete the following information):

  • OS: OS X Sonma 14.1 (23B74)
  • Browser: Chrome

Additional context
Rails version: 7.1.2
Ruby version: 3.2.2

Test failure:
Screenshot 2023-12-29 at 17 44 11
@tonxyx tonxyx changed the title Wrong destroy method call on non soft deletable Spree::Property Undefined destroy method call on non soft deletable Spree::Property Dec 29, 2023
@tonxyx tonxyx mentioned this issue Dec 29, 2023
Merged
@tonxyx tonxyx changed the title Undefined destroy method call on non soft deletable Spree::Property [Admin] Undefined destroy method call on non soft deletable Spree::Property Dec 29, 2023
@elia elia closed this as completed in #5577 Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix property destroy - use destroy instead of discard tonxyx/solidus
1 participant
@tonxyx