Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance log message for Bogus payments #5422

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

nirnaeth
Copy link
Contributor

@nirnaeth nirnaeth commented Oct 6, 2023

Summary

Fixes #4867.

For both bogus_credit_card and simple_bogus_credit_card, identifies the method from which the message is being created and adds that information to the log.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Fixes [solidusio#4867](solidusio#4867).

For both bogus_credit_card and simple_bogus_credit_card, identifies the method from which the
message is being created and adds that information to the log.
@nirnaeth nirnaeth requested a review from a team as a code owner October 6, 2023 12:05
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #5422 (abb004b) into main (2abc7d3) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##             main    #5422      +/-   ##
==========================================
- Coverage   88.86%   88.85%   -0.01%     
==========================================
  Files         607      607              
  Lines       14747    14755       +8     
==========================================
+ Hits        13105    13111       +6     
- Misses       1642     1644       +2     
Files Coverage Δ
...p/models/spree/payment_method/bogus_credit_card.rb 94.64% <92.85%> (+0.52%) ⬆️
...s/spree/payment_method/simple_bogus_credit_card.rb 57.89% <33.33%> (-4.61%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍 🙏

@elia elia self-assigned this Dec 19, 2023
@elia elia merged commit fb07e49 into solidusio:main Dec 19, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Bogus payment methods event names
2 participants