Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog entry for 2.11.17 release #4684

Conversation

forkata
Copy link
Contributor

@forkata forkata commented Oct 20, 2022

Summary

There is a breaking change in this release that is worth documenting for users who are updating and may not expect that in a patch version release. We will probably also want to update the Release entry to mention this, as that is what shows up when dependabot opens a PR for a version bump.

Fixes #4679.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • I have written a thorough PR description.
  • I have kept my commits small and atomic.
  • I have used clear, explanatory commit messages.

The following are not always needed (cross them out if they are not):

  • I have added automated tests to cover my changes.
  • I have attached screenshots to demo visual changes.
  • I have opened a PR to update the guides.
  • I have updated the readme to account for my changes.

This change updates the changelog to add a note regarding the need to
update configuration in applications that use `Spree::LogEntry` records
to store references to constants that are not already permitted.
The `*` indicates the beginning of a markdown tag and we should escape
it when using it in text.
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #4684 (bf8c2ab) into master (b9fd5ad) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4684   +/-   ##
=======================================
  Coverage   86.10%   86.10%           
=======================================
  Files         576      576           
  Lines       14627    14627           
=======================================
  Hits        12595    12595           
  Misses       2032     2032           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@waiting-for-dev waiting-for-dev merged commit 052234c into solidusio:master Oct 21, 2022
@waiting-for-dev
Copy link
Contributor

Thanks, @forkata! 🙌

@forkata forkata deleted the fix/update-changelog-for-2-11-17 branch October 26, 2022 23:19
@waiting-for-dev waiting-for-dev added the changelog:repository Changes to the repository not within any gem label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:repository Changes to the repository not within any gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.11.17 release contains a breaking change for YAML loading of LogEntry records
3 participants