Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kt-paperclip version mismatch #4308

Closed
tvdeyen opened this issue Mar 21, 2022 · 3 comments
Closed

kt-paperclip version mismatch #4308

tvdeyen opened this issue Mar 21, 2022 · 3 comments
Labels
changelog:solidus_core Changes to the solidus_core gem type:bug Error, flaw or fault

Comments

@tvdeyen
Copy link
Member

tvdeyen commented Mar 21, 2022

kt-paperclip is open ended in v2.11.5 but constrained to v6 in latest versions.
This allows paperclip v7 in 2.11.15 and only v6 in 3.0 and above. Not sure if this intentional
or a mistake. It surely is confusing for folks updating from v2 to v3

Solidus Version:

>= v2.11.15

To Reproduce

See the core gemspec in master https://github.com/solidusio/solidus/blob/master/core/solidus_core.gemspec#L44
The gemspec in v2.11.15 https://github.com/solidusio/solidus/blob/v2.11/core/solidus_core.gemspec#L42

Not sure what is the expected version. Happy to provide a PR if we agree on a version we want to support.

@spaghetticode
Copy link
Member

Definitely not intentional (I introduced KT-Paperclip on v2.11), I agree we should have the same high version constraint that we have in 3.x

@kennyadsl kennyadsl added type:bug Error, flaw or fault changelog:solidus_core Changes to the solidus_core gem labels Sep 2, 2022
@kennyadsl
Copy link
Member

@tvdeyen do you think we can close this one now? BTW, I saw that master now allows kt-paperclip 7 as well.

@tvdeyen
Copy link
Member Author

tvdeyen commented Sep 2, 2022

Yes

@tvdeyen tvdeyen closed this as completed Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem type:bug Error, flaw or fault
Projects
None yet
Development

No branches or pull requests

3 participants