-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create product through API doc is misleading #4058
Labels
Comments
Thanks for reporting. I honestly was aware of this due to #3983. I'm started taking a look at how to fix this and I think I'll submit a solution soon. |
Tracking down the list of request bodies we need to update in the openapi doc file:
I will submit one or more PR to address this problem. |
26 tasks
This is fixed now for all endpoints. Eg. https://solidus.docs.stoplight.io/api-reference/products/create-product Thanks for opening the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Create a product by following the documentation here https://solidus.docs.stoplight.io/api-reference/products/create-product is misleading since all the data must be sent through a "product" key (which is not mentioned at all in the documentation and was able to figure it out by looking at the code).
Solidus Version:
NA
To Reproduce
Current behavior
The documentation doesn't mention that the product's information must be sent inside of a "product" key, thus, the endpoint fails with a validation error.
Expected behavior
The documentation mentions the product key.
Screenshots
(Notice how the generated code doesn't include the product key)
Below is how it should be sent
![image](https://user-images.githubusercontent.com/1719111/117898628-c9c8ff00-b29b-11eb-9887-975dbe868d7c.png)
(Notice how the info gets sent inside of
{ "product": { ... } }
.Desktop (please complete the following information):
Additional context
NA
The text was updated successfully, but these errors were encountered: