-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set states_required
to false for Germany
#3803
Comments
Another example of a country where |
The same is true for the Netherlands and I believe for, most European countries. |
German addresses do not typically use states. See: https://www.angloinfo.com/how-to/germany/housing/postal-system
This can cause validation issues on things like
solidus_paypal_braintree
because PayPal will not return a state when the users selects a German address in PayPal.Valid German address in PayPal (no state):
![Screen Shot 2020-10-21 at 2 52 03 PM](https://user-images.githubusercontent.com/5720486/96775345-07704400-13ad-11eb-9448-808dc51e91c6.png)
the below error happens on submit with
![Screen Shot 2020-10-21 at 2 52 10 PM](https://user-images.githubusercontent.com/5720486/96775354-093a0780-13ad-11eb-80dc-97f215cc341a.png)
solidus_paypal_braintree
cart checkout on submit:I'm sure there are other countries like this, but Germany is the only one that I'm currently aware of.
states_required
is set to true automatically if the country has any subregions in Carmen, but it appears that that shouldn't happen in some cases. See here - I think that's where it's being set.The text was updated successfully, but these errors were encountered: