-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculator should always return a BigDecimal, but in same scenarios that's not happening #3756
Labels
type:bug
Error, flaw or fault
Comments
5 tasks
Hi! I did this PR #3789, let me know if I made a mistake or if can I improve something thanks. |
Hi, I would like to work in this issue. Could I? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The calculator should always return a BigDecimal, but that's not always the case.
For example the flat_rate calculator return 0 as Integer on the else branch.
If the calculator returns a type other than BigDecimal a warning will be issued by the adjustment action for the promotions,
for example create_quantity_adjustments.
I think that we should document this expected interface on the Calculator, and update our actual implementation to respect the expected interface.
I wasn't able to find a test that raises this warning on the Solidus codebase, we should probably add some tests to cover this case.
Solidus Version:
First found out on Solidus 2.5.2.
To Reproduce
Current behavior
Expected behavior
The text was updated successfully, but these errors were encountered: