Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backend Admin::Search controller #244

Closed
jhawthorn opened this issue Jul 30, 2015 · 3 comments
Closed

Remove backend Admin::Search controller #244

jhawthorn opened this issue Jul 30, 2015 · 3 comments
Milestone

Comments

@jhawthorn
Copy link
Contributor

Split from #240

This controller has two "lightweight" versions of existing api index actions. We should switch to using the API, but it's currently significantly slower.

We'll have to either optimize the endpoint, or allow specifying which fields we want (ex. ?fields=name,id or ?include=)

@bbuchalter
Copy link
Contributor

Now that #240 is merged, is there any reason we can't remove Admin::Search?

@bbuchalter
Copy link
Contributor

Firing up a dummy app and running rake routes shows admin_search_users and admin_search_products are still out there, but not in use anywhere. I suppose we'd need to deprecate those end points? If there is a good example of how to do that, I'd be happy to open a PR. Or perhaps we just remove them?

@cbrunsdon
Copy link
Contributor

Marked it down on my personal hit list, but closing this issue due to staleness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants