Consider including in core some methods from solidus_support #4597
kennyadsl
started this conversation in
New Features or Ideas
Replies: 2 comments
-
IMO, we can come up with the first one, including those methods in core but just a bit confuse with this one
As for option 2, we will have to maintain |
Beta Was this translation helpful? Give feedback.
0 replies
-
Sorry I mean
Good one 👍 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We are using here some code that is already wrapped into useful methods of solidus_core gem.
solidus_support
is a gem that is meant to be included by other extension to provide useful methods and uniform behaviors among extensions.I think it could be a good idea to include those methods in core and remove them from
solidus_core
solidus_support
since they could be useful in core as well.Another option could be adding
solidus_support
gem in core - IMHO the cons of this is that we also add to core things that will not directly be used in core and should stay into extensions only, but we probably already have something like that in core.This issue needs a deeper look at what's the best path for this.
Any feedback is welcome!
Beta Was this translation helpful? Give feedback.
All reactions