From faaaeb5a0fe3deaabbd853efab53cc5cf0261314 Mon Sep 17 00:00:00 2001
From: Elia Schito <elia@schito.me>
Date: Sat, 28 Jan 2023 16:47:32 +0100
Subject: [PATCH] Fix missing or bad closing tags

---
 .../app/views/spree/admin/stock_movements/index.html.erb    | 6 ++----
 .../spree/admin/style_guide/topics/forms/_inputs.html.erb   | 2 +-
 .../admin/style_guide/topics/messaging/_flashes.html.erb    | 2 +-
 .../admin/style_guide/topics/typography/_lists.html.erb     | 2 +-
 backend/app/views/spree/admin/tax_categories/index.html.erb | 1 +
 backend/app/views/spree/admin/users/items.html.erb          | 1 +
 6 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/backend/app/views/spree/admin/stock_movements/index.html.erb b/backend/app/views/spree/admin/stock_movements/index.html.erb
index f88822a715a..63641852a61 100644
--- a/backend/app/views/spree/admin/stock_movements/index.html.erb
+++ b/backend/app/views/spree/admin/stock_movements/index.html.erb
@@ -50,7 +50,7 @@
   </colgroup>
   <thead>
     <tr data-hook="admin_stock_movements_index_headers">
-      <th><%= Spree::StockMovement.human_attribute_name(:variant) %>
+      <th><%= Spree::StockMovement.human_attribute_name(:variant) %></th>
       <th><%= Spree::StockMovement.human_attribute_name(:quantity) %></th>
       <th><%= Spree::StockMovement.human_attribute_name(:originated_by) %></th>
     </tr>
@@ -58,9 +58,7 @@
   <tbody>
     <% @stock_movements.each do |stock_movement|%>
       <tr id="<%= spree_dom_id stock_movement %>" data-hook="admin_stock_movements_index_rows">
-        <td>
-          <%= display_variant(stock_movement) %>
-        </td>
+        <td><%= display_variant(stock_movement) %></td>
         <td><%= stock_movement.quantity %></td>
         <td><%= pretty_originator(stock_movement) %></td>
       </tr>
diff --git a/backend/app/views/spree/admin/style_guide/topics/forms/_inputs.html.erb b/backend/app/views/spree/admin/style_guide/topics/forms/_inputs.html.erb
index ab51c0b991d..dd81e8a8fcb 100644
--- a/backend/app/views/spree/admin/style_guide/topics/forms/_inputs.html.erb
+++ b/backend/app/views/spree/admin/style_guide/topics/forms/_inputs.html.erb
@@ -28,7 +28,7 @@
     <th>2/3 column<br>(main content area)</th>
     <th>1/3 column<br>(secondary content area)</th>
     <th>1/2 column<br>(main content, small screen)</th>
-    <th>1 column<br>(main & secondary content, small screen)
+    <th>1 column<br>(main &amp; secondary content, small screen)</th>
   </tr>
   <tr>
     <td>text field - 'normal'</td>
diff --git a/backend/app/views/spree/admin/style_guide/topics/messaging/_flashes.html.erb b/backend/app/views/spree/admin/style_guide/topics/messaging/_flashes.html.erb
index 5dd45c22f87..2413dc2cae2 100644
--- a/backend/app/views/spree/admin/style_guide/topics/messaging/_flashes.html.erb
+++ b/backend/app/views/spree/admin/style_guide/topics/messaging/_flashes.html.erb
@@ -7,7 +7,7 @@
     type = $(this).data('flashType');
 
     if (!$('.flash.' + type).is('*')) {
-      flash = $("<div class='flash'>")
+      flash = $("<div class='flash'></div>")
         .text(type)
         .addClass(type)
         .appendTo('.js-flash-wrapper')
diff --git a/backend/app/views/spree/admin/style_guide/topics/typography/_lists.html.erb b/backend/app/views/spree/admin/style_guide/topics/typography/_lists.html.erb
index c3635d7e71f..f3e3b9978b0 100644
--- a/backend/app/views/spree/admin/style_guide/topics/typography/_lists.html.erb
+++ b/backend/app/views/spree/admin/style_guide/topics/typography/_lists.html.erb
@@ -22,4 +22,4 @@
   <dd>List</dd>
   <dt>Term</dt>
   <dd>Description</dd>
-</ul>
+</dl>
diff --git a/backend/app/views/spree/admin/tax_categories/index.html.erb b/backend/app/views/spree/admin/tax_categories/index.html.erb
index c52f54e7a86..9017e043366 100644
--- a/backend/app/views/spree/admin/tax_categories/index.html.erb
+++ b/backend/app/views/spree/admin/tax_categories/index.html.erb
@@ -50,6 +50,7 @@
           <% if can?(:destroy, tax_category) %>
             <%= link_to_delete tax_category, no_text: true %>
           <% end %>
+        </td>
       </tr>
     <% end %>
   </tbody>
diff --git a/backend/app/views/spree/admin/users/items.html.erb b/backend/app/views/spree/admin/users/items.html.erb
index 4eab112855b..cf2373071c9 100644
--- a/backend/app/views/spree/admin/users/items.html.erb
+++ b/backend/app/views/spree/admin/users/items.html.erb
@@ -69,6 +69,7 @@
             </tr>
           <% end %>
         <% end %>
+      </tbody>
     </table>
   <% else %>
     <div class="no-objects-found">