Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rubygems release? #80

Closed
brchristian opened this issue Aug 1, 2020 · 5 comments
Closed

New rubygems release? #80

brchristian opened this issue Aug 1, 2020 · 5 comments
Labels

Comments

@brchristian
Copy link
Contributor

I notice that the last rubygems release of this extension was from 2016, and a lot has changed in the world of Solidus since then.

In fact, I cannot even install the most recent rubygems version!

If I create a brand new Ruby (2.6.6), Rails (5.1.7), Solidus (2.10.2), and solidus_related_products (1.1.0) application, I can’t run the migrations, as I get:

StandardError: Directly inheriting from ActiveRecord::Migration is not supported. Please specify the Rails release the migration was written for:

  class CreateRelationTypes < ActiveRecord::Migration[4.2]
/[ruby_path]/ruby/2.6.6/gems/activerecord-5.1.7/lib/active_record/migration.rb:525:in `inherited'
/[app_path]/db/migrate/20200801224231_create_relation_types.solidus_related_products.rb:2:in `<top (required)>'

I suspect this can be fixed by simply cutting a newer version of the gem!

@aldesantis
Copy link
Member

@brchristian thanks for noticing, we'll work on a new release on Friday!

@aldesantis
Copy link
Member

@brchristian I think it makes sense for #79 to be fixed, what do you think?

@brchristian
Copy link
Contributor Author

@aldesantis I'm not sure what's going on to cause #79! We are running the current github master in production so it's not affecting our production environment, but as I said in that issue, I wasn't able to get the current master working with a new store. So, not sure what might be going on there!

@aldesantis
Copy link
Member

@brchristian I'll take a look to understand if it's an issue with the gem or the Solidus install so that we know we're not releasing a broken gem. 🙂

@stale
Copy link

stale bot commented Oct 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 9, 2020
@stale stale bot closed this as completed Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants