Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag ordering causes hang #554

Open
bcomnes opened this issue Sep 6, 2023 · 6 comments
Open

Flag ordering causes hang #554

bcomnes opened this issue Sep 6, 2023 · 6 comments
Assignees
Labels
bug Something isn't working cli

Comments

@bcomnes
Copy link
Contributor

bcomnes commented Sep 6, 2023

Monor sharp edge:

ssc build -r -o test --headless

The app starts heedlessly, but never exits.

ssc build --headless -r -o test

The app runs headless and exists as expected.

No errors printed to the console.

@bcomnes bcomnes changed the title Flag ordering bug causes hang Flag ordering causes hang Sep 6, 2023
@chicoxyzzy
Copy link
Member

The path is always the last argument. We need a check that there's no arguments without - or -- prefix in the middle of the command

@bcomnes
Copy link
Contributor Author

bcomnes commented Sep 6, 2023

Could be user error too, but as noted, it was running heedlessly when the flag was at the end.

@jwerle jwerle added bug Something isn't working cli labels Sep 7, 2023
@nirajgeorgian
Copy link

hello team
i am new to open source contribution but have been working on js for quite a long.
can i start to look into this issue.

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Sep 12, 2023

Hey @nirajgeorgian. We appreciate any contributions. However, our CLI is written in C++. The issue should be fixed in the options parser

@nirajgeorgian
Copy link

I can still do that.
i have programmed a lot in my college days in c++ and i have been doing professionally in golang from past few years.

@chicoxyzzy
Copy link
Member

I can still do that. i have programmed a lot in my college days in c++ and i have been doing professionally in golang from past few years.

Please feel free to open a PR, and we'll review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli
Projects
None yet
Development

No branches or pull requests

4 participants