Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codebase needs a license file #965

Closed
renier opened this issue Jul 29, 2012 · 3 comments
Closed

Codebase needs a license file #965

renier opened this issue Jul 29, 2012 · 3 comments

Comments

@renier
Copy link
Contributor

renier commented Jul 29, 2012

Codebase should have a LICENSE file to leave no doubt as to the license this code is released under.
@3rd-Eden
Copy link
Contributor

See readme.md

Sent from my iPhone

On 29 jul. 2012, at 05:02, Renier [email protected] wrote:

Codebase should have a LICENSE file to leave no doubt as to the license this code is released under.

Reply to this email directly or view it on GitHub:
#965

@renier
Copy link
Contributor Author

renier commented Jul 29, 2012

That's great, but it's convention to put that in its own file.

@3rd-Eden
Copy link
Contributor

Feel free to make a pull request for it.

rauchg added a commit that referenced this issue Jul 31, 2012
@rauchg
Merge pull request #970 from renier/master
9dd8134 
Codebase needs a license file (#965)
lautis added a commit to lautis/socket.io that referenced this issue Aug 29, 2012
@lautis
Merge tag 'refs/tags/0.9.10' into flowdock
e4e5133 
Release 0.9.10

* tag 'refs/tags/0.9.10': (35 commits)
  Release 0.9.10
  Don't lowercase log messages
  Revert "Fix infinite recursion in Websocket parsers."
  Fix infinite recursion in Websocket parsers.
  Always set the HTTP response in case an error should be returned to the client
  Create or destroy the flash policy server on configuration change
  Honour configuration to disable flash policy server
  Release 0.9.9
  manager: added response to sync disconnect xhrs
  Revert "Fix disconnectSync getting ignored"
  Put license text in its own file (socketio#965)
  Add express 3.0 instructions on Readme.md
  Add warning to .listen() to ease the migration to Express 3.x
  restore compatibility with node 0.4.x
  Fix disconnectSync getting ignored
  Release 0.9.8
  Release 0.9.7
  tests: fixed tests for 0.8
  Prevent crash when socket leaves a room twice.
  Corrects unsafe usage of for..in, permitting socket.io to be used in environments where Object, Function, etc. have been extended.
  ...

Conflicts:
	lib/transports/jsonp-polling.js
	lib/transports/websocket/default.js
	lib/transports/websocket/hybi-16.js
	package.json
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@3rd-Eden @renier