-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implied void return-type and switch to fluent this return type #3776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Merged as 9e8f288. Thanks a lot! |
darrachequesne
pushed a commit
that referenced
this pull request
Feb 2, 2021
This was referenced Mar 10, 2021
Bump socket.io from 2.3.0 to 4.0.0 in /filiikot/rootfs/opt/filiikot
filii-lamberti/addon-filiikot#87
Closed
Closed
This was referenced Mar 11, 2021
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behavior
New behavior
ReturnType
. See this StackOverflow answer.Packages that use TypeScript and depend on this package should not experience any breakage or new compiler warnings as a result of this change.
Other information (e.g. related issues)
https://www.typescriptlang.org/docs/handbook/advanced-types.html#polymorphic-this-types
I am motivated to make this change because I am working on a type-utility for socket.io that would enable stronger type checking for
on
andemit
on both the client and server sides. It involves making interfaces that extend theSocket
class. Without polymorphicthis
, I wouldn't be able to chain fluent methods such ason
while keeping my extension-interface's special typings behaviour. Here is a discussion thread I started about this idea: #3777.