Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters are not explicit enough #8

Open
ampledata opened this issue May 18, 2021 · 0 comments
Open

Filters are not explicit enough #8

ampledata opened this issue May 18, 2021 · 0 comments

Comments

@ampledata
Copy link
Collaborator

ampledata commented May 18, 2021

Per classes.py, line 103:

                        if filter_key and filter_key in a_known_craft[self.known_craft_key].strip().upper():

Unfortunately that will match a filter_key of 441F to a a_known_craft[self.known_craft_key].strip().upper() of 441FA.

Instead what we should do is be explicit with something like:

                        if filter_key and filter_key is a_known_craft[self.known_craft_key].strip().upper():

Assuming the filter_key and a_known_craft[self.known_craft_key].strip().upper() are "clean" inputs (that is, no special characters inserted by the dump1090 decoder and a good-faith effort on the end-user on normalizing their filter data (e.g. no spaces/newlines/special characters/ALL CAPITALS/NO TRICK SPELLING).

https://www.youtube.com/watch?v=gSJeHDlhYls

https://www.youtube.com/watch?v=nzUY6Iiur6E

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant