Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image could have cron job for running artisan schedule:run #8722

Open
stefaro opened this issue Nov 11, 2020 · 1 comment
Open

Docker image could have cron job for running artisan schedule:run #8722

stefaro opened this issue Nov 11, 2020 · 1 comment
Assignees
Labels

Comments

@stefaro
Copy link

stefaro commented Nov 11, 2020

Is your feature request related to a problem? Please describe.
Setting up cron job for running schedule:run is cumbersome in docker image.

Describe the solution you'd like
I think there should be a cron job in docker image which would be controlled by an environment variable. A good default value for the value would be * * * * *, so that scheduled tasks work out of the box.
Installing the cron job would happen in startup.sh. Cron is already installed in the image, we just need to probably start it in the background. Starting cron daemon would also happen in startup.sh.

Describe alternatives you've considered
Environment value controlling the cron job could also be unset by default, and so the cron job wouldn't be installed at all.

Additional context
I think I can provide a pull request with these changes implemented, if this is concidered as a good idea.

@welcome
Copy link

welcome bot commented Nov 11, 2020

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants