Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine variant of Docker image doesn't run scheduled tasks #7969

Closed
JonathonReinhart opened this issue Apr 14, 2020 · 6 comments
Closed

Alpine variant of Docker image doesn't run scheduled tasks #7969

JonathonReinhart opened this issue Apr 14, 2020 · 6 comments
Labels

Comments

@JonathonReinhart
Copy link
Contributor

In #6606 I fixed the (then only) Docker image to run the Laravel schedule every minute in a simple sleep loop using Supervisor.

#6645 added an Alpine variant of the Docker image, but it appeared to be based on the old entrypoint.sh and none of my work. This effectively re-introduced all of the old problems for users of this new Docker image.

Now that Snipe-IT has two separate docker images, with completely different sets of supporting startup files, there will invariably be bugs that arise from the differences between them. I think that Snipe-IT should maintain only one Docker image to avoid the additional support issues.

I'm a fan of Alpine-based Docker images, so if Alpine is the way forward, I think we should:

cc @uberbrady @colin-campbell

@stale
Copy link

stale bot commented Jun 13, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Jun 13, 2020
@JonathonReinhart
Copy link
Contributor Author

Yuuuuup

@stale
Copy link

stale bot commented Jun 14, 2020

Okay, it looks like this issue or feature request might still be important. We'll re-open it for now. Thank you for letting us know!

@stale stale bot removed the stale label Jun 14, 2020
@stale
Copy link

stale bot commented Aug 16, 2020

Is this still relevant? We haven't heard from anyone in a bit. If so, please comment with any updates or additional detail.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Don't take it personally, we just need to keep a handle on things. Thank you for your contributions!

@stale stale bot added the stale label Aug 16, 2020
@stale
Copy link

stale bot commented Aug 23, 2020

This issue has been automatically closed because it has not had recent activity. If you believe this is still an issue, please confirm that this issue is still happening in the most recent version of Snipe-IT and reply to this thread to re-open it.

@stale stale bot closed this as completed Aug 23, 2020
@JonathonReinhart
Copy link
Contributor Author

@uberbrady ...per our recent conversation on #10626 about differences between the two docker images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant