-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please review fips gadget #102
Comments
You could have created an empty commit, push that to 22-fips and created a PR to it, I believe. Anyway, this is fine. Could not we just use Otherwise LGTM, although note that in the near future we are going to have an "append" to kernel command line option in gadget.yaml, so the cmdline.extra file will not be necessary anymore. |
I need it to stage the cmdline.extra file, cause with plugin:nil it doesn't exist. |
https://github.com/snapcore/pc-gadget/compare/22...22-fips?expand=1
Given it is not quite possible to generate a pull request without any shared history, I directly pushed this initial fips gadget packaging.
It currently stages existing gadget, and adds extra cmdline argument
fips=1
. I hope in the future to remove the extra cmdline argument. However 22-fips tracks will remain, to be able to control releases of gadgets w.r.t. signing keys used by kernel snaps.The text was updated successfully, but these errors were encountered: