{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":325640416,"defaultBranch":"main","name":"rover","ownerLogin":"smyrick","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2020-12-30T20:19:01.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/2446877?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1712073853.0","currentOid":""},"activityList":{"items":[{"before":"dc4181d1e64203b945dd383e3d4a68d24ebc76b8","after":null,"ref":"refs/heads/patch-1","pushedAt":"2024-04-02T16:04:13.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"}},{"before":"b85841df3db8eca2d867e543d81517c7f23e3914","after":"dc4181d1e64203b945dd383e3d4a68d24ebc76b8","ref":"refs/heads/patch-1","pushedAt":"2024-04-01T17:26:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Merge branch 'main' into patch-1","shortMessageHtmlLink":"Merge branch 'main' into patch-1"}},{"before":"a480fdf1fc0e7801804cc2f05e76679a2f314b00","after":"b85841df3db8eca2d867e543d81517c7f23e3914","ref":"refs/heads/patch-1","pushedAt":"2024-03-26T23:20:06.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Merge branch 'main' into patch-1","shortMessageHtmlLink":"Merge branch 'main' into patch-1"}},{"before":"572a7ba54f8d0d64b427883a250c1b193881d7f7","after":"7bc235ec951b230ca61c2c3c16a69f41f5b93acc","ref":"refs/heads/main","pushedAt":"2024-03-22T22:09:50.000Z","pushType":"push","commitsCount":48,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Use task specific `rayon` threadpools and not the global threadpool (#1872)\n\nThe global `rayon` threadpool has a variable number of threads:\r\n\r\n- An environment variable can be used to specify the number:\r\nRAYON_NUM_THREADS\r\n - If not set, The number of CPUs on the executing system is used\r\n\r\nRelying on using the global pool may lead to a situation where the\r\nglobal threadpool does not have enough threads for `rover dev` to\r\nexecute correctly. It's not realistic to expect customers to know how to\r\nset this environment variable and a better option is available.\r\n\r\nAt each point in `rover` where we use `rayon`, create a thread pool\r\nwhich is task specific and explicitly sets the number of threads\r\navailable to the pool.\r\n\r\nFor example:\r\n\r\n```\r\n    let tp = rayon::ThreadPoolBuilder::new()\r\n        .num_threads(1)\r\n        .thread_name(|idx| format!(\"router-runner-{idx}\"))\r\n        .build()\r\n        .map_err(|err| {\r\n            RoverError::new(anyhow!(\"could not create router runner thread pool: {err}\",))\r\n        })?;\r\n```\r\nThis has the added advantage of allowing us to provide a name for all\r\nthe threads created by the pool which is helpful debugging information.\r\n\r\nNote: It might be that a more comprehensive answer to this problem is to\r\nnot use `rayon` at all, but that's a bigger change than I want to\r\nconsider for fixing this specific issue.\r\n\r\nalso:\r\n- change the configuration of the `interprocess` crate so that\r\nnon-blocking isn't available (it's broken)\r\n - close `stdin` on our spawned router to reduce risk of bad input\r\n- handle errors if we can't take `stdout` || `stderr` from our spawned\r\nrouter\r\n\r\nI've tested these changes manually on my laptop by setting\r\nRAYON_NUM_THREADS=2 and using `rover dev` without observing any hangs.\r\nWithout these changes, `rover dev` hangs immediately.\r\n\r\nfixes: #1871","shortMessageHtmlLink":"Use task specific <code>rayon</code> threadpools and not the global threadpool (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2181811261\" data-permission-text=\"Title is private\" data-url=\"https://github.com/apollographql/rover/issues/1872\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/apollographql/rover/pull/1872/hovercard\" href=\"https://github.com/apollographql/rover/pull/1872\">a…</a>"}},{"before":"7bc235ec951b230ca61c2c3c16a69f41f5b93acc","after":"a480fdf1fc0e7801804cc2f05e76679a2f314b00","ref":"refs/heads/patch-1","pushedAt":"2024-03-22T19:57:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Update latest_plugin_versions.json","shortMessageHtmlLink":"Update latest_plugin_versions.json"}},{"before":"02042ef4ab2055790040bfb2e471676ca5fbb2a7","after":null,"ref":"refs/heads/patch-2","pushedAt":"2024-01-24T17:49:30.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"}},{"before":"3c72bbe9534d73942d5c3b35d610d01311c4d3d9","after":null,"ref":"refs/heads/patch-1","pushedAt":"2024-01-23T20:39:40.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"}},{"before":"b81a5812def3d3f224a73d2382c6d31b8346c2b6","after":"02042ef4ab2055790040bfb2e471676ca5fbb2a7","ref":"refs/heads/patch-2","pushedAt":"2024-01-23T20:01:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Update dev.mdx","shortMessageHtmlLink":"Update dev.mdx"}},{"before":"306a08547b65a1de5a4869e397640fd48c97eee3","after":"3c72bbe9534d73942d5c3b35d610d01311c4d3d9","ref":"refs/heads/patch-1","pushedAt":"2024-01-23T12:13:34.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"abernix","name":"Jesse Rosenberger","path":"/abernix","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/841294?s=80&v=4"},"commit":{"message":"Merge branch 'main' into patch-1","shortMessageHtmlLink":"Merge branch 'main' into patch-1"}},{"before":"60cb95d2144da4e8cc595b336e5072eed06fccd7","after":"306a08547b65a1de5a4869e397640fd48c97eee3","ref":"refs/heads/patch-1","pushedAt":"2024-01-23T10:43:16.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"abernix","name":"Jesse Rosenberger","path":"/abernix","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/841294?s=80&v=4"},"commit":{"message":"Merge branch 'main' into patch-1","shortMessageHtmlLink":"Merge branch 'main' into patch-1"}},{"before":"1bc7ff720ddbf28207575bb1aa4b2659fa05ae85","after":"572a7ba54f8d0d64b427883a250c1b193881d7f7","ref":"refs/heads/main","pushedAt":"2024-01-18T17:39:03.000Z","pushType":"push","commitsCount":145,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"feat: subgraph publish --no-url shorthand (#1809)\n\nThis is slightly more convenient and less awkward than `--routing-url \"\"\r\n--allow-invalid-routing-url`\r\n\r\n<!--\r\nFirst, 🌠 thank you 🌠 for taking the time to consider a contribution to\r\nApollo!\r\n\r\nHere are some important details to follow:\r\n\r\n* ⏰ Your time is important\r\nTo save your precious time, if the contribution you are making will\r\ntake more than an hour, please make sure it has been discussed in an\r\n        issue first. This is especially true for feature requests!\r\n\r\n* 💡 Features\r\nFeature requests can be created and discussed within a GitHub Issue.\r\nBe sure to search for existing feature requests (and related issues!)\r\nprior to opening a new request. If an existing issue covers the need,\r\nplease upvote that issue by using the 👍 emote, rather than opening a\r\n        new issue.\r\n\r\n* 🕷 Bug fixes\r\nThese can be created and discussed in this repository. When fixing a\r\nbug,\r\nplease _try_ to add a test which verifies the fix. If you cannot, you\r\nshould\r\nstill submit the PR but we may still ask you (and help you!) to create a\r\ntest.\r\n\r\n* 📖 Contribution guidelines\r\nFollow https://github.com/apollographql/rover/blob/HEAD/CONTRIBUTING.md\r\nwhen submitting a pull request. Make sure existing tests still pass, and\r\nadd\r\n        tests for all new behavior.\r\n\r\n* ✏️ Explain your pull request\r\nDescribe the big picture of your changes here to communicate to what\r\n        your pull request is meant to accomplish. Provide 🔗 links 🔗 to\r\n        associated issues!\r\n\r\nWe hope you will find this to be a positive experience! Open source\r\ncontribution can be intimidating and we hope to alleviate that pain as\r\nmuch\r\nas possible. Without following these guidelines, you may be missing\r\ncontext\r\nthat can help you succeed with your contribution, which is why we\r\nencourage\r\ndiscussion first. Ultimately, there is no guarantee that we will be able\r\nto\r\nmerge your pull-request, but by following these guidelines we can try to\r\navoid disappointment.\r\n\r\n-->\r\n\r\n---------\r\n\r\nCo-authored-by: Ben Newman <ben@benjamn.com>","shortMessageHtmlLink":"feat: subgraph publish --no-url shorthand (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2067705372\" data-permission-text=\"Title is private\" data-url=\"https://github.com/apollographql/rover/issues/1809\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/apollographql/rover/pull/1809/hovercard\" href=\"https://github.com/apollographql/rover/pull/1809\">apollographql#1809</a>)"}},{"before":"d64a0b113f5dd43c549ba63dda45b75d51a180bb","after":"60cb95d2144da4e8cc595b336e5072eed06fccd7","ref":"refs/heads/patch-1","pushedAt":"2024-01-02T23:48:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Meschreiber","name":"Maria Elisabeth Schreiber","path":"/Meschreiber","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/23219998?s=80&v=4"},"commit":{"message":"Apply suggestions from code review","shortMessageHtmlLink":"Apply suggestions from code review"}},{"before":"b99ba28187e2eb96d03a69972881f583d226cb6a","after":"d64a0b113f5dd43c549ba63dda45b75d51a180bb","ref":"refs/heads/patch-1","pushedAt":"2024-01-02T23:14:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Update supergraphs.mdx","shortMessageHtmlLink":"Update supergraphs.mdx"}},{"before":"206225ee4ce36be84b166939b47b524af61b85e8","after":"b99ba28187e2eb96d03a69972881f583d226cb6a","ref":"refs/heads/patch-1","pushedAt":"2023-12-20T22:19:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Update supergraphs.mdx","shortMessageHtmlLink":"Update supergraphs.mdx"}},{"before":"f9f4b2d265a7ad5b096896e0e746fd4a3d88af63","after":null,"ref":"refs/heads/patch-1","pushedAt":"2023-09-01T18:35:12.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"}},{"before":"228f008e72a4e95984c7852a26a40a717b6917af","after":"f9f4b2d265a7ad5b096896e0e746fd4a3d88af63","ref":"refs/heads/patch-1","pushedAt":"2023-08-31T18:57:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Meschreiber","name":"Maria Elisabeth Schreiber","path":"/Meschreiber","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/23219998?s=80&v=4"},"commit":{"message":"Update shell examples","shortMessageHtmlLink":"Update shell examples"}},{"before":"e2ba8f1756d2c403b35ab21c1a370c43d769c5f5","after":"228f008e72a4e95984c7852a26a40a717b6917af","ref":"refs/heads/patch-1","pushedAt":"2023-08-31T03:43:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Update template with list of templates","shortMessageHtmlLink":"Update template with list of templates"}},{"before":"988038ecd889e5c70420ec7534e59c9615e6c33e","after":null,"ref":"refs/heads/patch-1","pushedAt":"2023-08-01T19:55:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"}},{"before":"64ebe6ac81727840148517f33c4b67855f615b92","after":"988038ecd889e5c70420ec7534e59c9615e6c33e","ref":"refs/heads/patch-1","pushedAt":"2023-07-21T18:28:04.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Merge branch 'main' into patch-1","shortMessageHtmlLink":"Merge branch 'main' into patch-1"}},{"before":"79d34eb6e3b9b07c442f06dc142de7916a318a64","after":"64ebe6ac81727840148517f33c4b67855f615b92","ref":"refs/heads/patch-1","pushedAt":"2023-07-17T18:59:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"Update rover dev to make clear you can remove routing_url for graph ref","shortMessageHtmlLink":"Update rover dev to make clear you can remove routing_url for graph ref"}},{"before":"052fb913d72978a819c4ff1e6b3020144982676a","after":"1bc7ff720ddbf28207575bb1aa4b2659fa05ae85","ref":"refs/heads/main","pushedAt":"2023-04-22T01:01:33.000Z","pushType":"push","commitsCount":261,"pusher":{"login":"smyrick","name":"Shane Myrick","path":"/smyrick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2446877?s=80&v=4"},"commit":{"message":"docs: Fix a couple of typos in CHANGELOG (#1582)\n\n<!--\r\nFirst, 🌠 thank you 🌠 for taking the time to consider a contribution to\r\nApollo!\r\n\r\nHere are some important details to follow:\r\n\r\n* ⏰ Your time is important\r\nTo save your precious time, if the contribution you are making will\r\ntake more than an hour, please make sure it has been discussed in an\r\n        issue first. This is especially true for feature requests!\r\n\r\n* 💡 Features\r\nFeature requests can be created and discussed within a GitHub Issue.\r\nBe sure to search for existing feature requests (and related issues!)\r\nprior to opening a new request. If an existing issue covers the need,\r\nplease upvote that issue by using the 👍 emote, rather than opening a\r\n        new issue.\r\n\r\n* 🕷 Bug fixes\r\nThese can be created and discussed in this repository. When fixing a\r\nbug,\r\nplease _try_ to add a test which verifies the fix. If you cannot, you\r\nshould\r\nstill submit the PR but we may still ask you (and help you!) to create a\r\ntest.\r\n\r\n* 📖 Contribution guidelines\r\nFollow https://github.com/apollographql/rover/blob/HEAD/CONTRIBUTING.md\r\nwhen submitting a pull request. Make sure existing tests still pass, and\r\nadd\r\n        tests for all new behavior.\r\n\r\n* ✏️ Explain your pull request\r\nDescribe the big picture of your changes here to communicate to what\r\n        your pull request is meant to accomplish. Provide 🔗 links 🔗 to\r\n        associated issues!\r\n\r\nWe hope you will find this to be a positive experience! Open source\r\ncontribution can be intimidating and we hope to alleviate that pain as\r\nmuch\r\nas possible. Without following these guidelines, you may be missing\r\ncontext\r\nthat can help you succeed with your contribution, which is why we\r\nencourage\r\ndiscussion first. Ultimately, there is no guarantee that we will be able\r\nto\r\nmerge your pull-request, but by following these guidelines we can try to\r\navoid disappointment.\r\n\r\n-->\r\n\r\nCo-authored-by: Avery Harnish <avery@apollographql.com>","shortMessageHtmlLink":"docs: Fix a couple of typos in CHANGELOG (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1675589977\" data-permission-text=\"Title is private\" data-url=\"https://github.com/apollographql/rover/issues/1582\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/apollographql/rover/pull/1582/hovercard\" href=\"https://github.com/apollographql/rover/pull/1582\">apollographql#1582</a>)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEJbxynwA","startCursor":null,"endCursor":null}},"title":"Activity · smyrick/rover"}