Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add choose_multple function for choosing several values #55

Merged
merged 7 commits into from
Mar 23, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Mar 10, 2023

Builds on #29 for the new changes.

@notgull
Copy link
Member Author

notgull commented Mar 10, 2023

I'm not sure why the WASI test is failing; does WASI not support the alloc crate?

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 12, 2023

I'm not sure why the WASI test is failing; does WASI not support the alloc crate?

It's rustc regression introduced in 1.68; it should be fixed in the latest setup-cross-toolchain-action which includes taiki-e/setup-cross-toolchain-action@fd352f3.
EDIT: filed rust-lang/rust#109156 to fix rustc.

(I restarted CI)

@notgull notgull requested a review from fogti March 21, 2023 06:40
src/lib.rs Outdated Show resolved Hide resolved
@notgull notgull merged commit 5706126 into master Mar 23, 2023
@notgull notgull deleted the notgull/choose_multiple branch March 23, 2023 09:31
@notgull notgull mentioned this pull request Mar 31, 2023
@notgull notgull mentioned this pull request Jun 9, 2023
notgull added a commit that referenced this pull request Jun 9, 2023
- **Breaking:** Remove interior mutability from `Rng`. (#47)
- Add a `fork()` method. (#49)
- Add a `no_std` mode. (#50)
- Add an iterator selection function. (#51)
- Add a `choose_multiple()` function for sampling several elements from an iterator. (#55)
- Use the `getrandom` crate for seeding on WebAssembly targets if the `js` feature is enabled. (#60)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants